NIFI-14331 Allow for removing all undefined elements (not only top level keys) from the JSON when using JsonTreeReader and JsonRecordSetWriter. #9781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-s1
changed the title
pvillard31
requested changes
Mar 7, 2025
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml
Outdated
Show resolved
Hide resolved
|
@pvillard31 When you have a chance can you please review? Thanks! |
dan-s1
force-pushed
the
NIFI-14331
branch
2 times, most recently
from
56bcefa to
6ee0bf3
Compare
|
@exceptionfactory Can you please take a look at this PR? My team has a flow which is experiencing this bug and it would be great to have this fix. Thank you! |
mosermw
reviewed
Apr 24, 2025
| assertFalse(flowFile.getContent().contains("fieldThatShouldBeRemoved")); | ||
| final List<String> undefinedTopLevelKeys = List.of("undefinedKey", "undefinedObjectArray", "undefinedObject", "undefinedScalarArray"); | ||
|
|
||
| undefinedTopLevelKeys.forEach(undefinedTopLevelKey -> assertFalse(flowFile.getContent().contains(undefinedTopLevelKey))); |
There was a problem hiding this comment.
Could this be simplified to a single assert that the string "undefined" is not in the result? Perhaps you could add a comment stating this covers all of the cases "undefinedKey", "undefinedObjectArray", "undefinedObject", "undefinedScalarArray", "undefinedKeyInObject"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-14331
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation