-
Notifications
You must be signed in to change notification settings - Fork 542
HDDS-13212. [DiskBalancer] Fix Inconsistent Health Check in DiskBalancer Status for Specific Hosts #8610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: HDDS-5713
Are you sure you want to change the base?
Conversation
No such command.
|
/gemini review |
No such command.
|
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DiskBalancerManager.java
Outdated
Show resolved
Hide resolved
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DiskBalancerManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Gargi-jais11 for updating the patch and sorry for too many rounds of review.
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DiskBalancerManager.java
Outdated
Show resolved
Hide resolved
No issue. It's completly alright. |
@peterxcli Now you can review the patch with updated intergation test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gargi-jais11 please fix the findbugs failure
...-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/node/TestDiskBalancer.java
Outdated
Show resolved
Hide resolved
...-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/node/TestDiskBalancer.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Gargi-jais11 for updating the patch, other LGTM!
What changes were proposed in this pull request?
The DiskBalancerManager#getDiskBalancerStatus() method filters only healthy datanodes when querying all nodes, but returns all specified hosts regardless of their health. This inconsistency can lead to confusion or inaccurate monitoring.
This JIRA proposes applying the same IN_SERVICE and HEALTHY filters for specific hosts to ensure consistent behavior.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13212
How was this patch tested?
Tested manually on docker cluster.
related logs