Devops/removal of fflib mocks

[ImJohnMDaniel]

The class fflib_Mocks was a relic from the days prior to the introduction of theTest.createStub(System.Type, System.StubProvider) method. Need to remove the class and use the standard library approach of fflib_ApexMocks.mock() instead.

This change is 

[daveespo]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ImJohnMDaniel)

---

sfdx-source/apex-mocks/test/classes/fflib_ApexMocksTest.cls line 723 at r1 (raw file):

		// Given
		fflib_ApexMocks mocks = new fflib_ApexMocks();
		// fflib_MyList.IList mockList = new fflib_Mocks.Mockfflib_MyList(mocks);

Why leave a commented-out line here? (and below)

[ImJohnMDaniel]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ImJohnMDaniel)

sfdx-source/apex-mocks/test/classes/fflib_ApexMocksTest.cls line 723 at r1 (raw file):

		// Given
		fflib_ApexMocks mocks = new fflib_ApexMocks();
		// fflib_MyList.IList mockList = new fflib_Mocks.Mockfflib_MyList(mocks);

Why leave a commented-out line here? (and below)

@daveespo -- Good catch. I have removed the obsolete comments. Cheers!

[daveespo]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ImJohnMDaniel)