Fix/4372 skip null values in hal #7317
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks okay, could you fix the tests? (lowest branches tests don't matter they'll get fixed later) |
BacLuc
force-pushed
the
fix/4372-skip-null-values-in-HAL
branch
from
5784c52 to
5b4e937
Compare
I fixed most of them. I also did not change the changelog, because i don't have a hash of a commit in the api-platform repository yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: This PR adds support for skip_null_to_one_relations: false with relations to the HAL normalizer. This however deviates from the hyperschema, because now the entries in _links and _embedded may be null, which isn't really allowed in HAL.
Relates to:
Additionally:
Will do that if this has a chance of beeing merged.