Skip to content

feat(doctrine): improve http cache invalidation using the mapping #7319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mrossard
Copy link
Contributor

@mrossard mrossard commented Jul 27, 2025

Q A
Branch? main
Tickets Closes #6754

Thanks to the new ObjectMapper integration we have an "easy" way to fetch an ApiResource impacted by changes on a doctrine entity.

It makes it possible to greatly improve http cache invalidation, which is currently done in a doctrine listener, when using stateOptions.
This is not yet tested - this probably can't yield correct results without #7300 anyway.

@mrossard mrossard marked this pull request as draft July 27, 2025 13:59
@soyuka
Copy link
Member

soyuka commented Jul 29, 2025

that's really nice!

@soyuka
Copy link
Member

soyuka commented Jul 29, 2025

#7300 merged!

@mrossard
Copy link
Contributor Author

#7300 merged!

Cool, i'll try to write a relevant test for this (and do a cs-fixer pass)!

i was thinking about trying to add a hook for custom IRI gathering like mentioned in #6754 but that probably should be a separate PR.

@mrossard mrossard force-pushed the feat-cache-invalidation-using-mapping branch 4 times, most recently from 15a07e1 to 88b160c Compare July 29, 2025 15:14
@mrossard mrossard force-pushed the feat-cache-invalidation-using-mapping branch from 88b160c to ea26095 Compare July 29, 2025 16:07
@mrossard mrossard marked this pull request as ready for review July 29, 2025 16:41
@mrossard
Copy link
Contributor Author

If i'm not mistaken the test errors i get are not related...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HTTP Cache] Doesn't work with stateOptions
2 participants