Skip to content

fix(openapi): nullable default values in operation openapi definition #7321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2025
Merged

fix(openapi): nullable default values in operation openapi definition #7321

merged 1 commit into from
Jul 29, 2025

Conversation

soyuka
Copy link
Member

@soyuka soyuka commented Jul 29, 2025

@soyuka soyuka changed the base branch from main to 4.1 July 29, 2025 06:20
@soyuka soyuka mentioned this pull request Jul 29, 2025
Closed
snoob
snoob reviewed Jul 29, 2025
View reviewed changes
src/Metadata/Extractor/XmlResourceExtractor.php
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to fix the YamlResourceExtractor too ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably

snoob
snoob reviewed Jul 29, 2025
View reviewed changes
src/OpenApi/Model/Parameter.php
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are this changes still needed as the MR #7315 has been merged ?

Otherwise, i realized than i have done partially the job (see: #7322).
If you want to integrate this changes here i can decline the MR.

@soyuka soyuka merged commit d1abfc0 into api-platform:4.1 Jul 29, 2025
1 check failed
@soyuka
Copy link
Member Author

soyuka commented Jul 29, 2025

We need this at least for the schema and I think having defaults is still a nice thing to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoob snoob snoob left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soyuka @snoob @MrSrsen