gcsfuse_mount_spec parsing and supporting mount_options from command line #1290
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the command-line parsing for --gcsfuse_mount_spec to allow for multiple key-value pairs and robustly handle custom GCS FUSE mount_options.
Usage
The entire argument must be wrapped in single quotes ('...') to protect the inner double quotes from the shell.
No special quoting is needed.
Testing
Unit Tests: Added parameterized unit tests to validate the new parsing logic for various formats (complex, basic, and empty mount_options).
End-to-End Test: Confirmed the full functionality by successfully launching a Fuji 7B training job that used a custom GCS FUSE mount defined with this flag.
The existing mount flags hardcoded in the code are not changed and I do see errors with those but haven't changed them. Instead passing the mount options I need in the command.