Skip to content

feat: RUNFILES_DIR compatibility #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions js/private/js_binary.sh.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,12 @@ trap _exit EXIT
export RUNFILES
JS_BINARY__RUNFILES="$RUNFILES"
export JS_BINARY__RUNFILES
# Set RUNFILES_DIR for compatibility with languages obeying the design laid out in
# https://github.com/bazelbuild/bazel/issues/4460
if [ -z "${RUNFILES_DIR:-}" ]; then
RUNFILES_DIR="$RUNFILES"
fi
export RUNFILES_DIR

# ==============================================================================
# Prepare to run main program
Expand Down