-
-
Notifications
You must be signed in to change notification settings - Fork 422
ENH: querying tool for the Planetary Ring Node #2358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
6722d7a
started building infrastructure for solarsystem.pds.RingNode
d96fa2e
minimum working example. parses basic query for all six targets
21e146c
allowed option to pass observatory coordinates
ae97eb9
added some tests
b7d2751
attempted to fix all pep8 problems
d4b1f02
added units, some fixes suggested by mkelley
emolter 72a34be
added offline test
emolter 2dfa100
small fixes to tests, improved documentation
emolter c8f7b4c
added test for Pluto, wrote an rst file
emolter 44dc8f7
small fixes as suggested by mkelley, and trying to fix docs
emolter d6e7edf
tests for Saturn, Neptune special cases
emolter eb6a179
made (hopefully) all changes from code review
emolter b884513
made all changes suggested by @eerovaher
emolter 1d2621d
attempted fix to AttributeError: 'RingNodeClass' object has no attrib…
emolter 95c9570
complying with template in pull request #2341
emolter 66c87f2
fixes suggested by @eerovaher
emolter 65f5167
changes suggested by @bsipocz
emolter 3c92254
made adding units with QTable back-compatible with 3.7
emolter 550bd95
fixing oldest dependencies table read duplicate column error
a33753b
added support for jwst
9570932
forgot to test before push :facepalm:
55cea03
changes suggested by @bsipocz, most importantly adding platform-indep…
6cc3749
changelog entry
6448ab8
Addressing final review items
bsipocz 51ead5f
Fix windows parsing
bsipocz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,7 @@ MANIFEST | |
pip-wheel-metadata | ||
.hypothesis | ||
doctests.py | ||
coverage.xml | ||
|
||
# Sphinx | ||
_build | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
""" | ||
RingNode | ||
-------- | ||
|
||
:author: Ned Molter ([email protected]) | ||
""" | ||
|
||
from astropy import config as _config | ||
|
||
|
||
class Conf(_config.ConfigNamespace): | ||
""" | ||
Configuration parameters for `astroquery.solarsystem.pds`. | ||
""" | ||
|
||
# server settings | ||
url = _config.ConfigItem( | ||
"https://pds-rings.seti.org/cgi-bin/tools/viewer3_xxx.pl?", "Ring Node" | ||
) | ||
Comment on lines
+16
to
+19
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are different URLs possible? |
||
|
||
# implement later: other pds tools | ||
|
||
timeout = _config.ConfigItem(30, "Time limit for connecting to PDS servers (seconds).") | ||
|
||
|
||
conf = Conf() | ||
|
||
from .core import RingNode, RingNodeClass | ||
|
||
__all__ = [ | ||
"RingNode", | ||
"RingNodeClass", | ||
"Conf", | ||
"conf", | ||
] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.