Skip to content

refactor: improve amqp binding logic in AmqpConfig.java #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Manas-Dikshit
Copy link

@Manas-Dikshit Manas-Dikshit commented Mar 25, 2025

Summary

This pull request refactors the AMQP binding logic in AmqpConfig.java to enhance clarity and maintainability without altering functionality.

Changes

  • feat: Implemented a conditional check for AMQP channel binding in AmqpConfig.java.
  • fix: Corrected queue binding logic for AMQP to ensure proper functionality.
  • style: Adjusted formatting for better readability.
  • refactor: Refactored code snippets for improved clarity without functional changes.
  • perf: Optimized conditional checks to improve performance.

No Changes

  • docs: No documentation changes made.
  • test: No new tests added; existing tests remain unchanged.
  • build: No build system modifications.
  • ci: No CI configuration changes.
  • chore: General code tweaks that do not affect source or test files.
  • revert: No previous commits were reverted.

Issue Reference

Closes #434

Testing

  • Verified that the refactored logic does not break existing functionality.
  • Manually tested AMQP bindings to confirm correctness.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@Manas-Dikshit Manas-Dikshit changed the title Refactor AMQP Binding Logic in AmqpConfig.java refactor AMQP Binding Logic in AmqpConfig.java Mar 25, 2025
@Manas-Dikshit Manas-Dikshit changed the title refactor AMQP Binding Logic in AmqpConfig.java refactor AMQP binding logic in AmqpConfig.java Mar 25, 2025
@Manas-Dikshit Manas-Dikshit changed the title refactor AMQP binding logic in AmqpConfig.java refactor: improve amqp binding logic in AmqpConfig.java Mar 25, 2025
@Tenischev Tenischev self-assigned this Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants