Skip to content

feat: finish migrating to react renderer #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ibishal
Copy link

@ibishal ibishal commented Aug 25, 2024

Description

Updated this template to use react renderer

Related issue(s)
#294

Screenshot from 2024-08-26 03-10-19

Screenshot from 2024-08-26 03-11-40
Screenshot from 2024-08-26 03-10-02

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@ibishal
Copy link
Author

ibishal commented Aug 25, 2024

Can you review this PR,

then make it support asyncapi v3 - so 2 separate PR

so that i can proceed with this

cc @derberg

@ibishal
Copy link
Author

ibishal commented Sep 3, 2024

The package-lock.json is now included in the PR, and the test are working fine locally, can you rerun the test in this PR

cc @derberg

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good progres

left some suggestions

Copy link

sonarqubecloud bot commented Sep 5, 2024

@ibishal ibishal requested a review from derberg September 5, 2024 14:51
@ibishal
Copy link
Author

ibishal commented Sep 5, 2024

done the reviewed changes @derberg

@ibishal
Copy link
Author

ibishal commented Sep 11, 2024

pinging you again cc @derberg

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! did you try to use the template using https://github.com/asyncapi/nodejs-ws-template?tab=readme-ov-file#how-to-use-the-template instruction? I mean the react version?

when running ag command you need to reference local copy of react based template instead of @asyncapi/nodejs-ws-template

@ibishal
Copy link
Author

ibishal commented Feb 25, 2025

nice! did you try to use the template using https://github.com/asyncapi/nodejs-ws-template?tab=readme-ov-file#how-to-use-the-template instruction? I mean the react version?

when running ag command you need to reference local copy of react based template instead of @asyncapi/nodejs-ws-template

ig i have done that, as far as i remember

@ibishal
Copy link
Author

ibishal commented Feb 25, 2025

Lets push this by this weekend, its been pending for a long time

cc @derberg

Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jun 26, 2025
@ibishal
Copy link
Author

ibishal commented Jun 30, 2025

cc @derberg

@github-actions github-actions bot removed the stale label Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants