update: Update the Resource already exists condition reason
#177
Conversation
Currently the condition reason for the `Resource Already Exists` condition message instructs users to adopt the existing resource using the `AdoptResource` CRD, which we no longer implement. This change updates the message to instruct users to instead use the adoption by annotation feature to import an existing resource.
a-hilaly
added
the
do-not-merge/hold
|
/retest |
6 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
@michaelhtm these test look super flaky, are they related to the previous ec2 change? |
|
@a-hilaly the failing tests are mostly due to eventual consistency..I noticed the more tests we added the worse it got..maybe we can restructure it better |
|
/retest |
4 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
/unhold |
ack-prow
bot
removed
the
do-not-merge/hold
|
@michaelhtm: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test s3-controller-test |
|
/test ec2-controller-test |
Description of changes:
Currently the condition reason for the
Resource Already Existscondition message instructs users to adopt the existing resource
using the
AdoptResourceCRD, which we no longer implement.This change updates the message to instruct users to instead use
the adoption by annotation feature to import an existing resource.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.