Skip to content

fix: patch metadata and spec during Adopt adoption #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michaelhtm
Copy link
Member

@michaelhtm michaelhtm commented Apr 25, 2025

Description of changes:
Currently, when adoptionPolicy is adopt, when you call ReadOne
if the resource is found but there is an error (Eg. Resource
is not synced), the Spec fields do not get patched.

These changes ensure if the resource is found, even with errors, we
patch the Spec with latest fields

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Currently, when adoptionPolicy is `adopt`, when you call ReadOne and there's an
error, if the error is not a NotFound error, the Spec fields do not get
patched.
These changes ensure if the resource is found, even with errors, we
patch the Spec with latest fields
Copy link

ack-prow bot commented Apr 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: michaelhtm
Once this PR has been reviewed and has the lgtm label, please assign a-hilaly for approval by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot requested review from a-hilaly and jlbutler April 25, 2025 21:50
Copy link

ack-prow bot commented Apr 26, 2025

@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 86704a8 link false /test verify-attribution
ec2-controller-test 86704a8 link true /test ec2-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant