Skip to content

fix(amazonq): standardize reference type for reference log #7311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2025

Conversation

Hweinstock
Copy link
Contributor

@Hweinstock Hweinstock commented May 14, 2025

Problem

References are not added to the reference log at the bottom. The root cause is that the reference tracker log is expecting CW shaped references, but we are passing "Flare" shaped ones.

Solution

  • Update the reference log to standardize the shape of incoming references.

Testing and Verification

  • added unit test.
  • Verified e2e:
referenceTrackerDemo.mov

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

This comment was marked as off-topic.

@Hweinstock Hweinstock marked this pull request as ready for review May 14, 2025 20:57
@Hweinstock Hweinstock requested review from a team as code owners May 14, 2025 20:57
@Hweinstock Hweinstock merged commit ffb6ec1 into aws:feature/flare-inline May 14, 2025
18 of 22 checks passed
@Hweinstock Hweinstock deleted the fix/referenceTracker branch May 14, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants