Skip to content

fix(stepfunctions): Add document URI check for save telemetry #7315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(stepfunctions): Add document URI check for save telemetry #7315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fe3a16
Add document URI check for save telemetry
May 14, 2025
5311154
Add document URI check for save telemetry
May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions packages/core/src/stepFunctions/workflowStudio/workflowStudioEditor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,16 +147,18 @@ export class WorkflowStudioEditor {

// The text document acts as our model, thus we send and event to the webview on file save to trigger update
contextObject.disposables.push(
vscode.workspace.onDidSaveTextDocument(async () => {
await telemetry.stepfunctions_saveFile.run(async (span) => {
span.record({
id: contextObject.fileId,
saveType: 'MANUAL_SAVE',
source: 'VSCODE',
isInvalidJson: isInvalidJsonFile(contextObject.textDocument),
vscode.workspace.onDidSaveTextDocument(async (savedDocument) => {
if (savedDocument.uri.toString() === this.documentUri.toString()) {
await telemetry.stepfunctions_saveFile.run(async (span) => {
span.record({
id: contextObject.fileId,
saveType: 'MANUAL_SAVE',
source: 'VSCODE',
isInvalidJson: isInvalidJsonFile(contextObject.textDocument),
})
await broadcastFileChange(contextObject, 'MANUAL_SAVE')
})
await broadcastFileChange(contextObject, 'MANUAL_SAVE')
})
}
})
)

Expand Down
4 changes: 4 additions & 0 deletions packages/toolkit/.changes/next-release/Bug Fix-de3cdda1-252e-4d04-96cb-7fb935649c0e.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type": "Bug Fix",
"description": "Step Function performance metrics now accurately reflect only Workflow Studio document activity"
}
Loading