Skip to content

feat(chat): Add ripgrep path and make it executable #7325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025

Conversation

jguoamz
Copy link
Contributor

@jguoamz jguoamz commented May 15, 2025

Problem

  • AgenticChat will add a grepSearch tool which depends on ripgrep binary

Solution

  • Add ripgrep path and make it executable

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@jguoamz jguoamz force-pushed the ripGrep branch 2 times, most recently from af69644 to ccbda5b Compare May 15, 2025 22:40
@jguoamz jguoamz changed the title feat(chat): Add ripgrep path feat(chat): Add ripgrep path and make it executable May 15, 2025
@jguoamz jguoamz marked this pull request as ready for review May 15, 2025 23:50
@jguoamz jguoamz requested a review from a team as a code owner May 15, 2025 23:50
@leigaol leigaol merged commit 1d585e9 into aws:master May 19, 2025
30 of 31 checks passed
@jguoamz jguoamz deleted the ripGrep branch May 19, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants