Skip to content

[Hybrid Nodes] add details to Service Traffic Distribution guidance #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: mainline
Choose a base branch
from

Conversation

csplinter
Copy link
Contributor

@csplinter csplinter commented Apr 29, 2025

Description of changes:
This PR adds additional context for the recommendation to use Service Traffic Distribution over Topology Aware Routing for mixed mode clusters with both cloud and hybrid nodes

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@csplinter csplinter requested a review from fincd-aws as a code owner April 29, 2025 15:32
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-994.d3rijirjvbh87e.amplifyapp.com

@csplinter csplinter changed the title [Hybrid Nodes] add details to Topology Aware Routing configuration [Hybrid Nodes] add details to Service Traffic Distribution guidance Apr 29, 2025
@fincd-aws fincd-aws self-assigned this May 2, 2025
@geoffcline geoffcline requested a review from Copilot May 16, 2025 15:52
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates documentation to add additional context on using Service Traffic Distribution for mixed mode clusters with both cloud and hybrid nodes.

  • Updates vocabulary files by adding terms (CloudWatch, CoreDNS) for consistency.
  • Revises several user guide sections to clarify recommendations and configuration steps for webhooks, CoreDNS, and CNI settings.
  • Updates instructions and code snippets to reflect changes in the guidance on traffic distribution and operator deployment across hybrid and cloud nodes.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
vale/styles/config/vocabularies/EksDocsVocab/accept.txt Adds accepted terms for CloudWatch and CoreDNS.
latest/ug/nodes/hybrid-nodes-webhooks.adoc Revises language and configuration guidance for webhooks and mixed mode clusters.
latest/ug/nodes/hybrid-nodes-nodeadm.adoc Adds a new section for kubelet customization with nodeadm.
latest/ug/nodes/hybrid-nodes-cni.adoc Introduces new configuration for enabling service topology in the load balancer section.

@@ -96,35 +100,65 @@ spec:
...
----
+
. Add `trafficDistribution` to the kube-dns Service configuration.
. Add the setting `trafficDistribution: PreferClose` to the `kube-dns` Service configuration to enable Topology Aware Routing.
Copy link
Preview

Copilot AI May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an inconsistency between this instruction and the rest of the PR guidance. The title and earlier instructions suggest that Service Traffic Distribution is recommended over Topology Aware Routing. Please clarify whether the setting trafficDistribution: PreferClose is intended to enable Service Traffic Distribution or Topology Aware Routing and update the text accordingly.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants