Skip to content

added support to calculate all timings, even failed #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

added support to calculate all timings, even failed #348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ function cypressSplit(on, config, userSpecOrderFn = undefined) {
specAbsoluteToRelative[absoluteSpecPath] = spec.relative
})

let { SPLIT, SPLIT_INDEX, SPLIT_FILE, SPLIT_OUTPUT_FILE, ciName } =
let { SPLIT, SPLIT_INDEX, SPLIT_FILE, SPLIT_OUTPUT_FILE, SPLIT_ALL_TIMINGS, ciName } =
parseSplitInputs(process.env, config.env)

if (SPLIT_FILE) {
Expand Down Expand Up @@ -207,7 +207,7 @@ function cypressSplit(on, config, userSpecOrderFn = undefined) {
specResult.stats.tests === specResult.stats.pending
debug({ relativeName, passed, allPending })

if (passed || allPending) {
if (SPLIT_ALL_TIMINGS === 'true' || SPLIT_ALL_TIMINGS === true || passed || allPending) {
const duration = Math.round(
specResult.stats.duration ||
specResult.stats.wallClockDuration,
Expand Down
3 changes: 2 additions & 1 deletion src/parse-inputs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ function parseSplitInputs(env = {}, configEnv = {}) {
let SPLIT_FILE = env.SPLIT_FILE || configEnv.splitFile
let SPLIT_OUTPUT_FILE =
env.SPLIT_OUTPUT_FILE || configEnv.splitOutputFile || SPLIT_FILE
let SPLIT_ALL_TIMINGS = env.SPLIT_ALL_TIMINGS || configEnv.splitAllTimings || false

// some CI systems like TeamCity provide agent index starting with 1
// let's check for SPLIT_INDEX1 and if it is set,
Expand Down Expand Up @@ -55,7 +56,7 @@ function parseSplitInputs(env = {}, configEnv = {}) {
}
}

return { SPLIT, SPLIT_INDEX, SPLIT_FILE, SPLIT_OUTPUT_FILE, ciName }
return { SPLIT, SPLIT_INDEX, SPLIT_FILE, SPLIT_OUTPUT_FILE, SPLIT_ALL_TIMINGS, ciName }
}

/**
Expand Down