Generate a typedesc instruction once for record and tuple types

[chiranSachintha]

Purpose

$title.

Fixes #38844
Fixes #41946

In this PR, I have generated a new 'typedesc' (type descriptor) only once for the tuple and record.
For example:

type Foo record {||};
public function main() {
    Foo f = {};
    record {|int a;|} r = {a: 1};
}

We have desugared the above program as follows:

type Foo record {||};
typedesc<Foo> $typedesc$Foo = Foo;
public function main() {
    Foo f = {};
    typedesc<record {| int a; |}> $typedesc$$anonType$_0 = record {| int a; |}
    record {|int a;|} r = {a: 1};
}

We then use the generated 'typedesc' when creating a map value using that type.

Check List

• Read the Contributing Guide
• Updated Change Log
• Checked Tooling Support (#)
• Added necessary tests
  • Unit Tests
  • Spec Conformance Tests
  • Integration Tests
  • Ballerina By Example Tests
• Increased Test Coverage
• Added necessary documentation
  • API documentation
  • Module documentation in Module.md files
  • Ballerina By Examples

[heshanpadmasiri]

Shall we create a local variable for the result of referredType.getTag() (or use a switch on that), since we are using it 3 times in the if else block

[heshanpadmasiri]

Assuming we don't put null to symbolVarMap shall we change this such that we are not doing the lookup on symbolVarMap twice

Suggested change

	BIROperand symbolVarOperand = this.env.symbolVarMap.containsKey(typeSymbol.annotations) ?
	new BIROperand(this.env.symbolVarMap.get(typeSymbol.annotations)) :
	new BIROperand(this.globalVarMap.get(typeSymbol.annotations));
	BVarSymbol typeAnnotations = typeSymbol.annotations;
	BIRVariableDcl localDecl = this.env.symbolVarMap.get(typeAnnotations)
	BIROperand symbolVarOperand = localDecl != null ?
	new BIROperand(localDecl) :
	new BIROperand(this.globalVarMap.get(typeAnnotations));

[github-actions]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

[poorna2152]

nit

Suggested change

	} else {
	createNewTypedescInst(type, type, pos);
	return new BIRNonTerminator.NewStructure(pos, toVarRef, this.env.targetOperand, fields);
	}
	}
	createNewTypedescInst(type, type, pos);
	return new BIRNonTerminator.NewStructure(pos, toVarRef, this.env.targetOperand, fields);

[poorna2152]

Can't we separate Types.getImpliedType(type) into a variable so that function is called only once.

[poorna2152]

Suggested change

	} else {
	return new BIRNonTerminator.NewTypeDesc(position, toVarRef, resolveType, closures);
	}
	}
	return new BIRNonTerminator.NewTypeDesc(position, toVarRef, resolveType, closures);

[poorna2152]

Suggested change

[poorna2152]

Do we need a separate function for this as this wraps only a single statement

[github-actions]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

[github-actions]

Closed PR due to inactivity for more than 18 days.

[github-actions]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.