Add support for negative numbers in bevy_proto_bsn parsing #203
+26
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbuehler23
added
S-Needs-Review
|
@mmatvein needs help with Clippy :) |
villor
approved these changes
Jun 6, 2025
mmatvein
force-pushed
the
negative-numbers
branch
from
6ee730e to
89f8393
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
mmatvein
force-pushed
the
negative-numbers
branch
from
89f8393 to
ee4a363
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Negative numbers are parsed as an Unary operation containing the negative sign (-) and the number itself, instead of just as the plain number, which resulted in negative numbers in proto_bsn assets being interpret as
BsnValue::UnknownExprinstead of correctly asBsnValue::Number. This made it impossible to use negative numbers in proto_bsn assets.