Skip to content

feat(c-event-mutation): add eventCreateMutation #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(c-event-mutation): add eventCreateMutation #50

wants to merge 1 commit into from

Conversation

biantris
Copy link
Owner

@biantris biantris commented Jun 6, 2022

ref #37

  • Root collocation
  • Fix Root test
  • Add test to mutation

daniloab
daniloab reviewed Jun 6, 2022
View reviewed changes
src/components/event/eventCreate/mutations/EventCreateMutation.tsx
}
`;

export const updater: SelectorStoreUpdater = (store) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the new directives from relay to update connections https://relay.dev/docs/guided-tour/list-data/updating-connections/

daniloab
daniloab approved these changes Jun 6, 2022
View reviewed changes
Copy link

@daniloab daniloab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move from helper functions to connection directives

src/relay/mutationUtils.tsx
before?: boolean;
};

export function connectionUpdater({ store, parentId, connectionName, edge, before = false }: ConnectionUpdater) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you do not need these helpers since now has https://relay.dev/docs/guided-tour/list-data/updating-connections/

@daniloab
Copy link

daniloab commented Jun 6, 2022

breaking a test here https://github.com/biantris/graphql-relay-web/runs/6749228014?check_suite_focus=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniloab daniloab daniloab approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biantris @daniloab