Skip to content

MakerProcessesInputsForDepositTxRequest: Merge all error catching cases #7445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MakerProcessesInputsForDepositTxRequest: Merge all error catching cases #7445

wants to merge 1 commit into from

Conversation

alvasw
Copy link
Contributor

@alvasw alvasw commented Apr 29, 2025 •
edited by coderabbitai bot
Loading

We have failed(...) methods for Strings and Throwables. The failed(Throwable t) extracts the Throwable's message and appends it to the errorMessage. Therefore, both catch clauses are identical. We can remove the other catch clause because the most outer catch clause is identical to the inner one.

Relates to #7423.

Summary by CodeRabbit

  • Refactor
    • Updated the handling of trade price verification to allow errors to propagate naturally, removing previous exception handling logic.

@alvasw
MakerProcessesInputsForDepositTxRequest: Merge all error catching cases
b8b5b93 
We have `failed(...)` methods for `String`s and `Throwable`s. The
`failed(Throwable t)` extracts the `Throwable`'s message and appends it
to the `errorMessage`. Therefore, both catch clauses are identical. We
can remove the other catch clause because the most outer catch clause is
identical to the inner one.

Relates to bisq-network#7423
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 29, 2025 •
edited
Loading

Walkthrough

The change updates the logic in the MakerProcessesInputsForDepositTxRequest class by removing the try-catch block that previously handled exceptions during the retrieval and verification of the taker's trade price. Now, exceptions such as TradePriceOutOfToleranceException are no longer caught within this method and will propagate to the caller. The corresponding import statement for the removed exception handling was also deleted.

Changes

File Path Change Summary
core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerProcessesInputsForDepositTxRequest.java Removed the try-catch block around taker's trade price verification; deleted unused exception import.

Poem

A bunny once caught every fall,
But now lets exceptions stand tall.
No longer do errors hide in the brush—
They leap to the surface, no need to hush.
With code now more clear,
Bugs have less to fear—
The rabbit hops on, in exceptionless cheer!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dc878da and b8b5b93.

📒 Files selected for processing (1)
  • core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerProcessesInputsForDepositTxRequest.java (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Test Java 11, ubuntu-latest
  • GitHub Check: Test Java 11, macOS-latest
  • GitHub Check: Test Java 11, windows-latest
🔇 Additional comments (1)
core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerProcessesInputsForDepositTxRequest.java (1)

117-119: Code cleanup: Removed redundant try-catch block.

The removal of the nested try-catch block around these lines is a good simplification. Since the outer try-catch at lines 54-131 already catches all Throwable exceptions, having a separate inner try-catch was redundant. This change:

  1. Improves code readability
  2. Reduces duplication
  3. Maintains the same error handling behavior through the outer catch block

The exceptions thrown by request.getTradePrice(), offer.verifyTakersTradePrice(), and trade.setPriceAsLong() will now propagate to the outer catch block, which calls failed(t) - leading to the same end result with cleaner code.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@alvasw alvasw mentioned this pull request Apr 29, 2025
Merged
@thecockatiel
Copy link
Contributor

utACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alvasw @thecockatiel