Skip to content

Add stripWitness to Transaction Issue 2169 #2170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JacksonDMiller
Copy link
Contributor

This PR is intended to solve issue 2169

  • Adds a method to the transaction object to remove witness data.
    • This is needed to construct a coinbase transaction with properly formatted inputs.
  • Adds a test to cover the new method.

Credit to @benjamin-wilson for pointing it out in issue 1951

Copy link
Member

@junderw junderw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junderw junderw merged commit 32e08aa into bitcoinjs:master Sep 30, 2024
11 checks passed
@junderw
Copy link
Member

junderw commented Sep 30, 2024

Could you also open a PR against the v6 branch?

junderw added a commit that referenced this pull request Oct 1, 2024
…itnessesToTransaction

Update v6 branch: Add stripWitness to Transaction Issue 2169 #2170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants