Skip to content

[PM-19673] Add nodeSelector and tolerations #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

Invincibear
Copy link
Contributor

🎟️ Tracking

This is a re-implementation of #168, a PR that was never merged in due to not signing the disclosure agreement (which I have)

📔 Objective

Adds support to all templates for specifying nodeSelector & tolerations

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@S-Kakar
Copy link

S-Kakar commented Mar 29, 2025

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-19673

@S-Kakar S-Kakar changed the title Add nodeSelector and tolerations [PM-19673] Add nodeSelector and tolerations Mar 29, 2025
@S-Kakar S-Kakar added in-product-review Community PR is being reviewed by Bitwarden's Product team community-pr labels Mar 29, 2025
tolerations should be array of objects
@Invincibear
Copy link
Contributor Author

Invincibear commented Mar 29, 2025

I forgot to update charts/sm-operator/values.yaml to tolerations: [], I pushed the changes and am waiting for tests to run.

charts/self-host$ helm lint .
==> Linting .

1 chart(s) linted, 0 chart(s) failed
charts/sm-operator$ helm lint .
==> Linting .

1 chart(s) linted, 0 chart(s) failed

@Invincibear Invincibear requested a review from a team as a code owner May 2, 2025 05:41
@Invincibear Invincibear requested a review from Eeebru May 2, 2025 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-pr in-product-review Community PR is being reviewed by Bitwarden's Product team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants