Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

SIGINT-2299 #18

Merged
merged 6 commits into from
Oct 11, 2024
Merged

SIGINT-2299 #18

merged 6 commits into from
Oct 11, 2024

Conversation

jahid1209
Copy link
Collaborator

Address the recommendations from the jenkins-infra team mentioned here.

@jahid1209 jahid1209 merged commit 6af93c4 into main Oct 11, 2024
2 checks passed
try {
String proxy = getProxy(url, envVars, logger);
if (proxy.equals(ApplicationConstants.NO_PROXY)) {
ProxyConfiguration proxyConfig = Jenkins.get().proxy;
Copy link
Collaborator

@zaman-akib zaman-akib Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the requirements, users will pass HTTP_PROXY/http_proxy or HTTPS_PROXY/https_proxy (must use exact env variable name as we document these in the plugin docs) from Jenkinsfile or users will set these proxy details using these exact env variable names in their System environment variables and we will use those proxy to download bring-cli. Users will not set proxy through Jenkins Proxy Configuration.

Example Jenkinsfile -

pipeline {
    agent any
    environment {
        HTTPS_PROXY: 'https://example.proxy.com'
    }

    stages {
    // stages & steps here
    }
}

Please refer to this doc - https://documentation.blackduck.com/bundle/bridge/page/documentation/c_jenkins-additional-configs.html

That's why I believe we cannot replace the proxy related codes with Jekins proxy configuration. If we must update these then we need to confirm with PM.

@jahid1209 jahid1209 deleted the SIGINT-2299-dependency-update branch October 11, 2024 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants