build: remove drive patches #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 2, 2024
|
Had to revert frappe/drive@d371051 since it breaks CSS at quite a few places even if the JS built successfully. I'll just do that manually. |
|
@uhrjun Just a quick follow up, how is the release status on these two? I'd be happy to finish off this PR. 😄 |
|
Drive using npm instead of yarn complicated this a bit. I'll take a look at this again over the weekend. Some imports were failing when node_modules was not located within the frontend directory. If this is urgent, feel free to submit a pull request. Otherwise I'll get it done anyway but might take me longer. |
|
@uhrjun Hey Arjun! Were you able to make any progress on the migration to yarn? I'd really like to feature |
blaggacao
force-pushed
the
main
branch
7 times, most recently
from
3ba6963 to
5012afa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge once a fully patched version is released.
Depends on: