Skip to content

refactor: Migrate from playwright-lighthouse to lighthouse direct usage #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2025

Conversation

choiseona
Copy link
Member

๐Ÿ“‚ ์ž‘์—… ๋‚ด์šฉ

closes #52

  • playwright-lighthouse ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ์—์„œ lighthouse ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ๋กœ ๋งˆ์ด๊ทธ๋ ˆ์ด์…˜

๐Ÿ’ก ์ž์„ธํ•œ ์„ค๋ช…

1. playwright-lighthouse ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ ์ œ๊ฑฐ ๋ฐ lighthouse ๊ณต์‹ ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ๋กœ ๋งˆ์ด๊ทธ๋ ˆ์ด์…˜

์ดˆ๊ธฐ์—๋Š” ์‚ฌ์šฉ๋ฒ•์— ์ต์ˆ™ํ•˜์ง€ ์•Š์•„ playwright-lighthouse ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ๋ฅผ ํ†ตํ•ด ์„ฑ๋Šฅ ์ธก์ •์„ ๊ฐ„ํŽธํ•˜๊ฒŒ ๊ตฌํ˜„ํ–ˆ์—ˆ์Šต๋‹ˆ๋‹ค.

๊ทธ๋Ÿฌ๋‚˜ ํ•ด๋‹น ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ๋Š” ํ•„์ˆ˜์ ์ธ ์˜์กด์„ฑ์ด ์•„๋‹ˆ๋ฉฐ, ํ”„๋กœ์ ํŠธ์˜ ๋‹จ์ˆœ์„ฑ๊ณผ ์œ ์ง€๋ณด์ˆ˜์„ฑ์„ ๋†’์ด๊ธฐ ์œ„ํ•ด ๊ณต์‹ lighthouse ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ๋งŒ์„ ์‚ฌ์šฉํ•˜๋„๋ก ๋ฆฌํŒฉํ† ๋งํ•˜์˜€์Šต๋‹ˆ๋‹ค.

2. lighthouse.util.ts โ†’ lighthouse.helper.ts๋กœ ํŒŒ์ผ๋ช… ๋ณ€๊ฒฝ

๊ธฐ์กด ํŒŒ์ผ์˜ ๊ธฐ๋Šฅ์€ ์ผ๋ฐ˜์ ์ธ ์œ ํ‹ธ ํ•จ์ˆ˜๋ผ๊ธฐ๋ณด๋‹ค๋Š” ํŠน์ • ๊ธฐ๋Šฅ์„ ๋ณด์กฐํ•˜๋Š” ์—ญํ• ์— ๊ฐ€๊นŒ์›Œ, ๋ณด๋‹ค ๋ช…ํ™•ํ•œ ๋ชฉ์ ์„ ๋“œ๋Ÿฌ๋‚ด๊ธฐ ์œ„ํ•ด ํŒŒ์ผ๋ช…์„ helper๋กœ ๋ณ€๊ฒฝํ•˜์˜€์Šต๋‹ˆ๋‹ค.

๐Ÿ“— ์ฐธ๊ณ  ์ž๋ฃŒ & ๊ตฌํ˜„ ๊ฒฐ๊ณผ (์„ ํƒ)

https://band-channel-d23.notion.site/230e4aabe3228037b997d2718843490b?source=copy_link

๐Ÿ“ข ๋ฆฌ๋ทฐ ์š”๊ตฌ ์‚ฌํ•ญ (์„ ํƒ)

๐Ÿšฉ ํ›„์† ์ž‘์—… (์„ ํƒ)

โœ… ์…€ํ”„ ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • PR ์ œ๋ชฉ์„ ํ˜•์‹์— ๋งž๊ฒŒ ์ž‘์„ฑํ–ˆ๋‚˜์š”?
  • ๋ธŒ๋žœ์น˜ ์ „๋žต์— ๋งž๋Š” ๋ธŒ๋žœ์น˜์— PR์„ ์˜ฌ๋ฆฌ๊ณ  ์žˆ๋‚˜์š”? (main์ด ์•„๋‹™๋‹ˆ๋‹ค.)
  • ์ด์Šˆ๋Š” close ํ–ˆ๋‚˜์š”?
  • Reviewers, Labels๋ฅผ ๋“ฑ๋กํ–ˆ๋‚˜์š”?
  • ์ž‘์—… ๋„์ค‘ ๋ฌธ์„œ ์ˆ˜์ •์ด ํ•„์š”ํ•œ ๊ฒฝ์šฐ ์ž˜ ์ˆ˜์ •ํ–ˆ๋‚˜์š”?
  • ํ…Œ์ŠคํŠธ๋Š” ์ž˜ ํ†ต๊ณผํ–ˆ๋‚˜์š”?
  • ๋ถˆํ•„์š”ํ•œ ์ฝ”๋“œ๋Š” ์ œ๊ฑฐํ–ˆ๋‚˜์š”?

Copy link

๐Ÿ“š Storybook preview deployed to: Visit Storybook Preview

Copy link

๐Ÿšฆ Lighthouse Audit Results

MainPage

Category Scores

Category Score
performance ๐ŸŸข 96
accessibility ๐ŸŸข 100
best-practices ๐ŸŸข 96
seo ๐ŸŸข 92

Core Web Vitals & Metrics

Metric Value Score
FCP 1.5ย s ๐ŸŸข 96
LCP 2.7ย s ๐ŸŸก 85
TBT 0ย ms ๐ŸŸข 100
CLS 0 ๐ŸŸข 100
SI 1.5ย s ๐ŸŸข 100
LobbyPage

Category Scores

Category Score
performance ๐ŸŸก 78
accessibility ๐ŸŸข 96
best-practices ๐ŸŸข 96
seo ๐ŸŸข 92

Core Web Vitals & Metrics

Metric Value Score
FCP 2.0ย s ๐ŸŸก 84
LCP 5.3ย s ๐Ÿ”ด 21
TBT 10ย ms ๐ŸŸข 100
CLS 0 ๐ŸŸข 100
SI 2.5ย s ๐ŸŸข 98

Copy link
Collaborator

@dbjoung dbjoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค..! ํ”„๋กœ์ ํŠธ ๊พธ์ค€ํžˆ ์‚ดํŽด์ฃผ์…”์„œ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค.
๋„˜ ์‹ ๊ธฐํ•˜๋„ค์š” : D ๊ธฐ์ˆ  ๋กœ๊ทธ๋„ ์ž˜ ์ฝ๊ฒ ์Šต๋‹ˆ๋‹ค.

@choiseona choiseona changed the title Refactor: Migrate from playwright-lighthouse to lighthouse direct usage refactor: Migrate from playwright-lighthouse to lighthouse direct usage Jul 18, 2025
@choiseona choiseona merged commit f292120 into main Jul 26, 2025
3 checks passed
Copy link

๐Ÿงน Storybook preview for PR #53 has been removed.

github-actions bot added a commit that referenced this pull request Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿ’ป FE Frontend Code ๐Ÿ”จ Refactor Code Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

๋ผ์ดํŠธํ•˜์šฐ์Šค ์ž๋™ํ™” ๋ฆฌํŒฉํ† ๋ง
3 participants