Skip to content

Conversation

choiseona
Copy link
Member

@choiseona choiseona commented Jul 21, 2025

๐Ÿ“‚ ์ž‘์—… ๋‚ด์šฉ

closes #54

  • hooks/game์— ๊ฒŒ์ž„ ๋กœ์ง ๊ด€๋ฆฌ

๐Ÿ’ก ์ž์„ธํ•œ ์„ค๋ช…

1. ๊ฒŒ์ž„ ๋กœ์ง hooks/game์— ๋ชจ์œผ๊ธฐ

  • ๊ธฐ์กด์˜ ๊ฐ ์ปดํฌ๋„ŒํŠธ์— ํฉ์–ด์ ธ์žˆ๋˜ ๊ฒŒ์ž„ ๋กœ์ง๋“ค์„ hooks/game ํด๋”์— ๋ชจ์•˜์Šต๋‹ˆ๋‹ค.
  • ์ „์ฒด์ ์ธ ๊ฒŒ์ž„ ๋กœ์ง ๊ฒ€ํ† ์˜ ๋ถˆํŽธํ•จ๊ณผ ์ปดํฌ๋„ŒํŠธ ํŒŒ์ผ์ด ๊ธธ์–ด์ง€๋Š” ๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ–ˆ์Šต๋‹ˆ๋‹ค.

2. ์†Œ์ผ“ ํ•ธ๋“ค๋Ÿฌ ์ค‘๋ณต ์ฝ”๋“œ ๊ฐœ์„ 

  • ๋ฐ˜๋ณต๋˜๋Š” ์†Œ์ผ“ ํ•ธ๋“ค๋Ÿฌ ์ฝ”๋“œ๋ฅผ ๊ณตํ†ต ํ—ฌํผ ํ•จ์ˆ˜๋กœ ํ†ตํ•ฉํ•˜์—ฌ ์ค„์˜€์Šต๋‹ˆ๋‹ค.

๊ฐœ์„  ์ „ (์ค‘๋ณต ์ฝ”๋“œ)

// ๋ชจ๋“  ํ•ธ๋“ค๋Ÿฌ์—์„œ ๋ฐ˜๋ณต๋˜๋Š” ํŒจํ„ด
const socket = useSocketStore.getState().sockets.game;
if (!socket) throw new Error('Socket not connected');
return new Promise(() => {
 socket.emit('joinRoom', request);
});

๊ฐœ์„  ํ›„

// ๊ณตํ†ต ๋กœ์ง์„ ํ—ฌํผ ํ•จ์ˆ˜๋กœ ์ถ”์ถœ
export const sendSocketMessage = (socketType, eventName, message) => {
  const socket = useSocketStore.getState().sockets[socketType];
  if (!socket) throw new Error(`${socketType} socket not connected`);
  return new Promise((resolve) => {
    socket.emit(eventName, message);
    resolve();
  });
};

// ๊ฐ ํ•ธ๋“ค๋Ÿฌ๋Š” ํ•œ ์ค„๋กœ ๊ฐ„์†Œํ™”
  joinRoom: (message: JoinRoomRequest): Promise<void> => {
    return sendGameMessage('joinRoom', message);
  },

  updateSettings: (message: UpdateSettingsRequest): Promise<void> => {
    return sendGameMessage('updateSettings', message);
  },

๐Ÿ“— ์ฐธ๊ณ  ์ž๋ฃŒ & ๊ตฌํ˜„ ๊ฒฐ๊ณผ (์„ ํƒ)

https://band-channel-d23.notion.site/234e4aabe322802fa329c2218a9f80a7?source=copy_link

๐Ÿ“ข ๋ฆฌ๋ทฐ ์š”๊ตฌ ์‚ฌํ•ญ (์„ ํƒ)

๐Ÿšฉ ํ›„์† ์ž‘์—… (์„ ํƒ)

โœ… ์…€ํ”„ ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • PR ์ œ๋ชฉ์„ ํ˜•์‹์— ๋งž๊ฒŒ ์ž‘์„ฑํ–ˆ๋‚˜์š”?
  • ์ด์Šˆ๋Š” close ํ–ˆ๋‚˜์š”?
  • Reviewers, Labels๋ฅผ ๋“ฑ๋กํ–ˆ๋‚˜์š”?
  • ์ž‘์—… ๋„์ค‘ ๋ฌธ์„œ ์ˆ˜์ •์ด ํ•„์š”ํ•œ ๊ฒฝ์šฐ ์ž˜ ์ˆ˜์ •ํ–ˆ๋‚˜์š”?
  • ํ…Œ์ŠคํŠธ๋Š” ์ž˜ ํ†ต๊ณผํ–ˆ๋‚˜์š”?
  • ๋ถˆํ•„์š”ํ•œ ์ฝ”๋“œ๋Š” ์ œ๊ฑฐํ–ˆ๋‚˜์š”?

@choiseona choiseona self-assigned this Jul 21, 2025
@choiseona choiseona added ๐Ÿ’ป FE Frontend Code ๐Ÿ”จ Refactor Code Refactoring labels Jul 21, 2025
Copy link

๐Ÿ“š Storybook preview deployed to: Visit Storybook Preview

Copy link

๐Ÿšฆ Lighthouse Audit Results

MainPage

Category Scores

Category Score
performance ๐ŸŸข 96
accessibility ๐ŸŸข 100
best-practices ๐ŸŸข 96
seo ๐ŸŸข 92

Core Web Vitals & Metrics

Metric Value Score
FCP 1.5ย s ๐ŸŸข 96
LCP 2.7ย s ๐ŸŸก 85
TBT 0ย ms ๐ŸŸข 100
CLS 0 ๐ŸŸข 100
SI 1.5ย s ๐ŸŸข 100
LobbyPage

Category Scores

Category Score
performance ๐ŸŸก 68
accessibility ๐ŸŸข 96
best-practices ๐ŸŸข 96
seo ๐ŸŸข 92

Core Web Vitals & Metrics

Metric Value Score
FCP 3.1ย s ๐Ÿ”ด 45
LCP 5.6ย s ๐Ÿ”ด 18
TBT 10ย ms ๐ŸŸข 100
CLS 0 ๐ŸŸข 100
SI 6.3ย s ๐Ÿ”ด 42

Copy link
Collaborator

@dbjoung dbjoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

game ํด๋” ๋‚ด์— ๊ด€๋ จ ํ›…๋“ค ๋ชจ์•„์„œ ์ •๋ฆฌํ•˜๋‹ˆ ํ›จ์”ฌ ์ ‘๊ทผํ•˜๊ธฐ ํŽธํ•ด์ง„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.
๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค..! ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค. : )

Copy link
Collaborator

@rhino-ty rhino-ty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!

@choiseona choiseona merged commit b2e5650 into main Aug 7, 2025
3 checks passed
Copy link

github-actions bot commented Aug 7, 2025

๐Ÿงน Storybook preview for PR #55 has been removed.

github-actions bot added a commit that referenced this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿ’ป FE Frontend Code ๐Ÿ”จ Refactor Code Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

๊ฒŒ์ž„ ๋กœ์ง ํ•œ ํด๋”์—์„œ ๊ด€๋ฆฌ
3 participants