Skip to content

fixed output message when apikey is not present #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yash1744
Copy link
Contributor

@yash1744 yash1744 commented Apr 2, 2025

why

solves issue #592.

what changed

Added intEnv in getBrowser method in order to know about initial environment and replaced env with intEnv for checking the environment correctly and outputting the message accordingly.

test plan

it correctly displays the error message if `env` is set to BROWSERBASE and apikey is undefined.
Copy link

changeset-bot bot commented Apr 2, 2025

⚠️ No Changeset found

Latest commit: a2be951

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR refines the error handling in the getBrowser function by introducing intEnv to better determine and log the intended environment when an API key is missing.

  • Updated /lib/index.ts: getBrowser now uses intEnv over the original env.
  • Improved output message when operating in BROWSERBASE mode without an API key.
  • Defaulting to LOCAL still occurs, so users must verify their intended environment setting.

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Member

@kamath kamath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks so much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants