Skip to content

feat: add USE_OWN_LOCAL_BINARY_PROCESS option to control local binary usage #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ruturaj-browserstack
Copy link
Contributor

This pull request introduces a new configuration option, USE_OWN_LOCAL_BINARY_PROCESS, to allow users to use their own BrowserStack Local binary process instead of starting a new one. The changes include updates to the configuration class, conditional logic in the local binary setup, and error handling in the accessibility scanner. Below is a summary of the most important changes:

Configuration Updates:

  • Added a new property, USE_OWN_LOCAL_BINARY_PROCESS, to the Config class in src/config.ts, allowing users to specify whether to use their own BrowserStack Local binary process. This is set based on the environment variable USE_OWN_LOCAL_BINARY_PROCESS. [1] [2]

Local Binary Setup:

  • Updated the ensureLocalBinarySetup function in src/lib/local.ts to skip the setup process if USE_OWN_LOCAL_BINARY_PROCESS is enabled, logging a message to indicate this behavior.

Accessibility Scanner:

  • Added error handling in the AccessibilityScanner class in src/tools/accessiblity-utils/scanner.ts to prevent scanning with local URLs when USE_OWN_LOCAL_BINARY_PROCESS is enabled, throwing an error with a clear message.

@ruturaj-browserstack ruturaj-browserstack marked this pull request as ready for review June 26, 2025 12:38
@tech-sushant
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants