Fix UI for Firecracker actions that aren't snapshotted #9753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
reviewed
Jun 24, 2025
There was a problem hiding this comment.
After taking another look at VMMetadata, it has some fields that seem like they might be set even if the VM wasn't resumed from a snapshot - should we update getVMMetadata to instead avoid setting the snapshot-related fields, but keep the other fields?
Right now vm_id is the only field that seems like it's not necessarily snapshot-related - not a terribly useful field, but I could see us adding other fields in the future and forgetting to update this logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/buildbuddy-io/buildbuddy-internal/issues/5208