Skip to content

Add Location labels #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

Add Location labels #1

wants to merge 17 commits into from

Conversation

kerlos
Copy link

@kerlos kerlos commented Mar 3, 2025

  • Location Labels
    image

  • Thai language translations

  • set default language via ?lang querystring (example lang=Thai)

  • toggle show version with ?version=false

@c-ola
Copy link
Owner

c-ola commented Mar 3, 2025

It seems like you reformatted the whole repo, so it's very difficult for me to read the diff. I'll add a format config and then ask you to send the changes again.

@c-ola
Copy link
Owner

c-ola commented Mar 3, 2025

Also, how did you generate the Thai language data for everything?

@c-ola
Copy link
Owner

c-ola commented Mar 3, 2025

Also what does the deploy.js script do.
I don't see the point of this since from what I can tell jekyll doesn't matter here, and it only adds needless complexity.

@c-ola
Copy link
Owner

c-ola commented Mar 4, 2025

You should also squash the commits a little

@kerlos
Copy link
Author

kerlos commented Mar 4, 2025

Also, how did you generate the Thai language data for everything?

I created script to read data from English for each field, then translate using Claude, after that I created another script to set all translations back into each field

@kerlos
Copy link
Author

kerlos commented Mar 4, 2025

Also what does the deploy.js script do. I don't see the point of this since from what I can tell jekyll doesn't matter here, and it only adds needless complexity.

Edit: in below issues there's a script to fixes that so i'll remove deploy.js script

Somehow my gh-pages cli doesn't work so I created deploy script in case cli didn't work

Here's the issue related to my case

gitname/react-gh-pages#211

kerlos added 6 commits March 4, 2025 09:57
add location labels
blur image direactly to fixed blur border
add default language on enter website
add ability to disable version ui
add deploy with script command
@c-ola
Copy link
Owner

c-ola commented Mar 4, 2025

Also, how did you generate the Thai language data for everything?

I created script to read data from English for each field, then translate using Claude, after that I created another script to set all translations back into each field

I don't think I want to add translations that are not official, and they complicate my data generation scripts.

@kerlos
Copy link
Author

kerlos commented Mar 4, 2025

Closing PR due to too many changes was made. going to hard fork instead.

@kerlos kerlos closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants