fix(network-activity-plugin): rewrite cookie parser to match RN specific logic #61
+365
−310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NepeinAV is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
V3RON
reviewed
Aug 14, 2025
| @@ -10,6 +10,7 @@ import { getNetworkRequestsRegistry } from './network-requests-registry'; | |||
| import { getBlobName } from '../utils/getBlobName'; | |||
| import { getFormDataEntries } from '../utils/getFormDataEntries'; | |||
| import { XHRInterceptor } from './xhr-interceptor'; | |||
| import { applyReactNativeResponseHeadersLogic } from '../../utils/applyReactNativeResponseHeadersLogic'; | |||
There was a problem hiding this comment.
You are crossing the device <-> DevTools UI boundary. This is potentially dangerous and can result in unwanted modules to be included in the bundle. I suggest moving it to the 'shared' directory.
There was a problem hiding this comment.
Do you just want to move this file to a shared directory? Right now it is only used on RN side (and always will be), so maybe not shared, but react-native?
There was a problem hiding this comment.
My fault. Noticed relative paths in both sub-directories and assumed the source is in 'ui' 🙈
V3RON
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Features: Enhanced Cookie Parser and Multi-Value Header Support
What's Done:
• Fixed cookie parsing to match React Native specific networking logic
• Headers that contain array values now display as multiple rows
• Simplified and refactored
CookiesTab.tsxto use the new parserBefore:
2025-08-13.01.06.48.mp4
After:
2025-08-13.01.05.27.mp4