Debugging in CI, ignore. #505
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...because fewer special cases are better. This also resolves everything but the documentation for capnproto#423. One of the tests had to be reworked a bit because the exact sequence of messages was a bit different, but still correct.
Per Louis's questions.
Temporary, for debugging, to see which one we're getting
Harder to parse the output otherwise, though I think these are not real, in the sense that this field is not accessed concurrently, though the rest of the object may be.
The error we're getting suggests a nil client; this patch should see if the client is actually null.
I think this is harmless, because Release() is idempotent, but the call to rel() already covers this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't reproduce the CI errors in #502 locally, so I'm going to use this PR to debug them in CI. feel free to unsubscribe and ignore; it won't be merged.