fix: added the ability to inform the worker's client that the Http Se… #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rver start failed
|
@chudnyi Thanks for your contribution! It looks pretty good, but there's no test in your pull request covering this scenario. Could you add a test case to ensure that the proper errors are thrown and are able to be handled? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a problem when
deno-vmis used in a Docker container in which the Deno process does not start, callback inthis._httpServer.listencrashes, http server not started. In this case, there is no way for the client code of the application to find out about this and somehow handle the situation.Messages that are sent via
postMessageare stored in_pendingMessagesand will never be processed.My solution is not the best, but I implemented it so as not to change the library interface.