Skip to content

fix: firtool lowering options CLI flag #4924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edwardcwang
Copy link
Contributor

As of firtool 1.62.0 the format is --lowering-options=...

Type of Improvement

Documentation or website-related

Desired Merge Strategy

Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

As of `firtool` 1.62.0 the format is `--lowering-options=...`
@edwardcwang edwardcwang requested a review from seldridge May 13, 2025 04:42
@edwardcwang edwardcwang added Squash and merge These commits don't matter, squash and merge Documentation Only changing documentation labels May 13, 2025
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine to do, though unnecessary.

LLVM tools will accept either version. I.e., -lowering-options or --lowering-options are the same. The help text, however, always shows a -- for the options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Only changing documentation Squash and merge These commits don't matter, squash and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants