ws_main.py: Make --sanitized work with clang #1170
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While compiling with: """ CC=clang CXX=clang++ ./b configure --sanitized CC=clang CXX=clang++ ./b build """ I got: """ clang: error: unknown argument '-static-libasan'; did you mean '-static-libsan'? """ This commit passes expected param name to clang while still passing the other one to gcc. With commit applied, one can successfully build and run sanitized clang-compiled trex binaries.
pespin
force-pushed
the
pespin/pr-clang-asan
branch
from
54533ba to
71f9b6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While compiling with:
"""
CC=clang CXX=clang++ ./b configure --sanitized
CC=clang CXX=clang++ ./b build
"""
I got:
"""
clang: error: unknown argument '-static-libasan'; did you mean '-static-libsan'? """
This commit passes expected param name to clang while still passing the other one to gcc.
With commit applied, one can successfully build and run sanitized clang-compiled trex binaries.