Skip to content

Documentation ignores the \b characters in docstrings #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

KnownNexus
Copy link
Contributor

Following from [1] seemingly stagnating,
I have reimplemented philipstarkey's fix for
"Documentation ignores the \b characters in docstrings"
in hopes of getting the ball rolling again

[1] #8

Following from [1] seemingly stagnating,
I have reimplemented philipstarkey's fix for
"Documentation ignores the \b characters in docstrings"
in hopes of getting the ball rolling again

[1] click-contrib#8
@codecov-io
Copy link

codecov-io commented Oct 1, 2018

Codecov Report

Merging #29 into master will increase coverage by 1.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   70.81%   71.87%   +1.06%     
==========================================
  Files           1        1              
  Lines         185      192       +7     
  Branches       49       51       +2     
==========================================
+ Hits          131      138       +7     
  Misses         46       46              
  Partials        8        8
Impacted Files Coverage Δ
sphinx_click/ext.py 71.87% <100%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b7888c...f6aafad. Read the comment docs.

@stephenfin
Copy link
Member

I pushed a change to add tests for this. It looks good to me and I'll merge once all the tests have passed.

@stephenfin stephenfin merged commit 090b3ed into click-contrib:master Oct 3, 2018
@KnownNexus KnownNexus deleted the Slash_b_ignored_in_docstrings branch October 8, 2018 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants