Ensure the storage is setup when using the size_sync outside of the class #1034
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
size_sync
method of the storage component is used by other components. For example, when preparing a report, the report might use thesize_sync
method, which uses other components. If the storage isn'tsetup
, this leads to a PHP fatal error.Approach
$this->media
is missingQA notes
Two options:
$this->plugin->get_component( 'storage' )->size_sync( $media_id );
outside of the Storage component.local_size
orremote_size
, and generate a report. Previously, it caused errors.