Skip to content

reafactor database_manager #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

michalkrzyz
Copy link
Collaborator

@michalkrzyz michalkrzyz commented May 8, 2025

Description

remove redundant code
add functions to make the code more readable and maintainable

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@michalkrzyz michalkrzyz force-pushed the mikrzyz/remove-redundant-code branch 6 times, most recently from d42c6f2 to a089575 Compare May 13, 2025 11:25
@michalkrzyz michalkrzyz self-assigned this May 13, 2025
On-behalf-of: SAP Michal Krzyz <[email protected]>
Signed-off-by: Michal Krzyz <[email protected]>
On-behalf-of: SAP Michal Krzyz <[email protected]>
Signed-off-by: Michal Krzyz <[email protected]>
@michalkrzyz michalkrzyz force-pushed the mikrzyz/remove-redundant-code branch from 0d1ad99 to 3da49fa Compare May 16, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant