Skip to content

Add an option to edmFileUtil to print information on clusters #48044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

makortel
Copy link
Contributor

@makortel makortel commented May 8, 2025

PR description:

This PR adds --printClusters command line option to edmFileUtil. The information on the cluster boundaries, number of entries per cluster, and the total size of baskets in a cluster was useful in the investigation of #47750.

Resolves cms-sw/framework-team#1386

PR validation:

Cluster information is getting printed on a random AOD file.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2025

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • IOPool/Common (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented May 8, 2025

@cmsbuild, please test

@makortel
Copy link
Contributor Author

makortel commented May 8, 2025

@dan131riley @Dr15Jones If we want to use the information on the cluster boundaries or number of entries per cluster (or total size of all baskets in a cluster), this code shows how to do that.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2025

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-391d28/45975/summary.html
COMMIT: 7b336e8
CMSSW: CMSSW_15_1_X_2025-05-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48044/45975/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4037687
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4037664
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #48044 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

@makortel
Copy link
Contributor Author

makortel commented May 13, 2025

@cmsbuild, please test

@makortel
Copy link
Contributor Author

Comparison differences are related to #47071

@makortel
Copy link
Contributor Author

Improved one comment

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #48044 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-391d28/46130/summary.html
COMMIT: b2e64e2
CMSSW: CMSSW_15_1_X_2025-05-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48044/46130/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4038193
  • DQMHistoTests: Total failures: 49
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4038124
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor Author

Comparison differences are related to #47071

@makortel
Copy link
Contributor Author

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 49783f4 into cms-sw:master May 14, 2025
11 checks passed
@makortel makortel deleted the edmFileUtilClusters branch May 14, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to edmFileUtil to print out information on clusters
4 participants