Fix SoftMuonMvaRun3Estimator for NaN chi2 (PromptReco issue) #48115

gpetruc · 2025-05-18T16:14:09Z

PR description:

Fix the SoftMuonMvaRun3Estimator to handle cases where a muon global track chi2 is NaN, which otherwise causes the pat::XGBooster to throw an exception as if the variable had not been initialized.

See #48063

PR validation:

The usual code-format, code-checks, runtests, runTheMatrix.py -l limited -i all --ibeos.

In 15_0_6 also tested it on the exception mentioned in the github issue #48063 from run 391884 and a similar one in the newer run 329112 ( https://cmsweb.cern.ch/t0_reqmon/data/jobdetail/PromptReco_Run392112_ParkingSingleMuon4 )

@24LopezR @llunerti

cmsbuild · 2025-05-18T16:14:36Z

cms-bot internal usage

cmsbuild · 2025-05-18T16:16:19Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48115/44867

cmsbuild · 2025-05-18T16:16:45Z

A new Pull Request was created by @gpetruc for master.

It involves the following packages:

PhysicsTools/PatAlgos (reconstruction, xpog)

@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@AlexDeMoor, @Ming-Yan, @Senphy, @ahinzmann, @andrzejnovak, @azotz, @castaned, @gkasieczka, @gouskos, @hatakeyamak, @jdamgov, @jdolen, @mariadalfonso, @mbluj, @mmarionncern, @nhanvtran, @rappoccio, @schoef, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

gpetruc · 2025-05-18T16:20:04Z

@cmsbuild, please test

cmsbuild · 2025-05-18T18:10:03Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5990e6/46231/summary.html
COMMIT: 8c75508
CMSSW: CMSSW_15_1_X_2025-05-18-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48115/46231/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4038193
DQMHistoTests: Total failures: 25
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4038148
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 215 log files, 184 edm output root files, 50 DQM output files
TriggerResults: no differences found

jfernan2 · 2025-05-19T08:06:30Z

+1

ftorrresd · 2025-05-19T15:14:54Z

enable nano

ftorrresd · 2025-05-19T15:14:58Z

please test

cmsbuild · 2025-05-19T17:20:41Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5990e6/46240/summary.html
COMMIT: 8c75508
CMSSW: CMSSW_15_1_X_2025-05-19-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48115/46240/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 2 lines from the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4038193
DQMHistoTests: Total failures: 73
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4038100
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 215 log files, 184 edm output root files, 50 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially added 913 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 25
DQMHistoTests: Total histograms compared: 93222
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 93222
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 24 files compared)
Checked 121 log files, 69 edm output root files, 25 DQM output files
TriggerResults: no differences found

Nano size comparison Summary:

workflow	id	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
NANOmc106Xul16v2	2500.001	3.115	3.115	0.000 ( +0.0% )	6.38	6.54	-2.4%	2.535	2.600
NANOmc106Xul17v2	2500.002	3.231	3.231	0.000 ( +0.0% )	5.27	5.77	-8.6%	2.987	3.067
NANOmc106Xul18v2	2500.003	3.172	3.172	0.000 ( +0.0% )	5.91	5.93	-0.3%	2.970	3.059
NANOdata106Xul16v2	2500.011	1.647	1.647	0.000 ( +0.0% )	10.37	11.75	-11.8%	2.633	2.640
NANOdata106Xul17v2	2500.012	2.185	2.185	0.000 ( +0.0% )	5.99	6.08	-1.5%	2.781	2.784
NANOdata106Xul18v2	2500.013	2.002	2.002	0.000 ( +0.0% )	8.24	8.69	-5.1%	2.691	2.711
NANOmcUL16APVreMINI	2500.021	0.022	0.022	0.000 ( +0.0% )	1.40	1.89	-25.6%	2.581	2.587
NANOmcUL16reMINI	2500.022	0.022	0.022	0.000 ( +0.0% )	1.32	1.78	-26.3%	2.574	2.591
NANOmcUL17reMINI	2500.023	0.022	0.022	0.000 ( +0.0% )	1.25	1.60	-21.5%	2.543	2.565
NANOmcUL18reMINI	2500.024	0.022	0.022	0.000 ( +0.0% )	1.08	1.43	-24.0%	2.714	2.727
NANOdataUL16APVreMINI	2500.031	0.035	0.035	0.000 ( +0.0% )	1.22	1.61	-24.3%	2.664	2.689
NANOdataUL16reMINI	2500.032	0.036	0.036	0.000 ( +0.0% )	1.29	1.62	-20.1%	2.592	2.617
NANOdataUL17reMINI	2500.033	0.037	0.037	0.000 ( +0.0% )	1.24	1.55	-19.8%	2.682	2.726
NANOdataUL18reMINI	2500.034	0.036	0.036	0.000 ( +0.0% )	1.25	1.57	-20.3%	2.677	2.688
NANOmc130X	2500.101	2.872	2.872	0.000 ( +0.0% )	13.82	15.85	-12.8%	2.665	2.663
NANOdata130Xrun3	2500.111	1.474	1.474	0.000 ( +0.0% )	25.40	30.83	-17.6%	2.397	2.397
NANOdata130Xrun3	2500.112	1.896	1.896	0.000 ( +0.0% )	21.69	24.94	-13.0%	2.294	2.315
ScoutingNANOdata130Xrun3	2500.131	0.771	0.771	0.000 ( +0.0% )	31.23	34.33	-9.0%	1.528	1.657
NANOmc140X	2500.201	2.706	2.706	0.000 ( +0.0% )	12.85	13.97	-8.1%	2.140	2.154
NANOdata140Xrun3	2500.211	1.845	1.845	0.000 ( +0.0% )	23.17	26.46	-12.4%	2.286	2.311
NANOdata140Xrun3	2500.212	2.243	2.243	0.000 ( +0.0% )	18.77	21.80	-13.9%	2.350	2.361
muPOGNANOmc140X	2500.221	2.141	2.141	0.000 ( +0.0% )	11.76	13.71	-14.2%	1.905	1.912
EGMNANOmc140X	2500.222	3.516	3.516	0.000 ( +0.0% )	11.19	12.79	-12.6%	1.952	1.976
BTVNANOmc140X	2500.223	10.328	10.328	0.000 ( +0.0% )	4.02	4.65	-13.4%	2.091	2.125
jmeNANOmc140X	2500.224	6.593	6.593	0.000 ( +0.0% )	1.18	1.23	-4.0%	2.129	2.276
jmeNANOrePuppimc140X	2500.225	6.641	6.641	0.000 ( +0.0% )	1.10	1.12	-2.2%	2.265	2.274
lepTrackInfoNANOmc140X	2500.226	3.210	3.210	0.000 ( +0.0% )	11.78	13.36	-11.8%	1.942	1.942
ScoutingNANOmc140X	2500.227	1.486	1.486	0.000 ( +0.0% )	15.17	15.92	-4.7%	1.839	1.856
ScoutingNANOwithPromptmc140X	2500.228	4.105	4.105	0.000 ( +0.0% )	8.11	7.96	+1.8%	2.370	2.467
BPHNANOmc140X	2500.229	3.798	3.798	0.000 ( +0.0% )	11.61	12.87	-9.8%	1.941	1.937
muPOGNANO140Xrun3	2500.231	1.516	1.516	0.000 ( +0.0% )	19.66	21.58	-8.9%	2.175	2.184
EGMNANOdata140Xrun3	2500.232	2.502	2.502	0.000 ( +0.0% )	19.12	20.73	-7.7%	2.261	2.247
BTVNANOdata140Xrun3	2500.233	5.422	5.422	0.000 ( +0.0% )	6.44	6.98	-7.7%	2.453	2.396
jmeNANOdata140Xrun3	2500.234	3.931	3.931	0.000 ( +0.0% )	1.51	1.47	+3.0%	2.316	2.310
jmeNANOrePuppidata140Xrun3	2500.235	3.961	3.961	0.000 ( +0.0% )	1.43	1.40	+2.5%	2.577	2.656
lepTrackInfoNANOdata140Xrun3	2500.236	2.292	2.292	0.000 ( +0.0% )	19.86	21.64	-8.2%	2.243	2.231
ScoutingNANOdata140Xrun3	2500.237	1.101	1.101	0.000 ( +0.0% )	28.88	28.76	+0.4%	1.580	1.647
ScoutingNANOwithPromptdata140Xrun3	2500.238	2.595	2.595	0.000 ( +0.0% )	14.10	13.06	+7.9%	2.560	2.555
BPHNANOdata140Xrun3	2500.239	2.535	2.535	0.000 ( +0.0% )	18.87	20.42	-7.6%	2.202	2.197
l1DPGNANO140Xrun3	2500.241	9.404	9.404	0.000 ( +0.0% )	6.93	6.84	+1.3%	1.814	1.810
muDPGNANO140Xrun3	2500.242	10.331	10.331	0.000 ( +0.0% )	1.45	1.61	-10.0%	1.658	1.659
muDPGNANOBkg140Xrun3	2500.243	2.712	2.712	0.000 ( +0.0% )	15.64	14.36	+8.9%	1.059	1.059
hcalDPGNANO140Xrun3	2500.244	486.016	486.016	0.000 ( +0.0% )	1.12	0.99	+13.5%	1.687	1.654
hcalDPGCalibNANO140Xrun3	2500.245	826.413	826.413	0.000 ( +0.0% )	1.50	1.43	+4.4%	1.591	1.631
hcalDPGMCNANO140Xrun3	2500.251	645.333	645.333	0.000 ( +0.0% )	1.61	1.51	+6.9%	1.661	1.742
NANOmc2024reMINI	2500.301	0.021	0.021	0.000 ( +0.0% )	1.59	1.36	+16.9%	3.089	3.082
NANOdata2024reMINI	2500.311	0.036	0.036	0.000 ( +0.0% )	1.60	1.17	+36.1%	2.671	2.679
NANOmc150X	2500.321	3.236	3.236	0.000 ( +0.0% )	19.02	17.54	+8.5%	2.712	2.705
NANOdata150X	2500.331	2.292	2.292	0.000 ( +0.0% )	31.51	27.13	+16.2%	2.339	2.446
TTbarMINIAOD10.6_UL18v2	2500.901	1.819	1.819	0.000 ( +0.0% )	30.84	27.51	+12.1%	1.792	1.792
TTbarMINIAOD14.0	2500.902	1.665	1.665	0.000 ( +0.0% )	31.10	28.72	+8.3%	1.465	1.463
DYToLL_M-50_13TeV_pythia8	2500.911	14.345	14.345	0.000 ( +0.0% )	7.64	7.07	+8.0%	1.101	1.095
DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV	2500.912	0.199	0.150	0.049 ( +32.8% )	3.41	2.03	+67.7%	0.851	0.851
TTbar_Pow_LHE_13TeV	2500.913	0.110	0.110	0.000 ( +0.0% )	2.62	2.33	+12.2%	0.852	0.851

antoniovilela · 2025-05-20T15:09:45Z

ping @cms-sw/xpog-l2

hqucms · 2025-05-20T15:12:49Z

+1

cmsbuild · 2025-05-20T15:13:06Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2025-05-20T17:57:09Z

+1

Fix for NaN chi2, see cms-sw#48063

8c75508

cmsbuild added this to the CMSSW_15_1_X milestone May 18, 2025

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels May 18, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels May 18, 2025

cmsbuild added tests-started and removed tests-pending labels May 18, 2025

gpetruc mentioned this pull request May 18, 2025

[15.0.X] Fix SoftMuonMvaRun3Estimator for NaN chi2 (PromptReco issue) #48116

Merged

cmsbuild added tests-approved and removed tests-started labels May 18, 2025

cmsbuild added reconstruction-approved and removed reconstruction-pending labels May 19, 2025

jfernan2 mentioned this pull request May 19, 2025

Rare exception in PromptReco from SoftMuonMvaRun3Estimator (muon with NaN globalTrack chi2) #48063

Open

cmsbuild added tests-started and removed tests-approved labels May 19, 2025

cmsbuild removed the tests-started label May 19, 2025

cmsbuild added the tests-approved label May 19, 2025

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels May 20, 2025

cmsbuild added orp-approved and removed orp-pending labels May 20, 2025

cmsbuild merged commit a2c23cc into cms-sw:master May 20, 2025
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix SoftMuonMvaRun3Estimator for NaN chi2 (PromptReco issue) #48115

Fix SoftMuonMvaRun3Estimator for NaN chi2 (PromptReco issue) #48115

Uh oh!

gpetruc commented May 18, 2025

Uh oh!

cmsbuild commented May 18, 2025 •

edited

Loading

Uh oh!

cmsbuild commented May 18, 2025

Uh oh!

cmsbuild commented May 18, 2025

Uh oh!

gpetruc commented May 18, 2025

Uh oh!

cmsbuild commented May 18, 2025

Uh oh!

jfernan2 commented May 19, 2025

Uh oh!

ftorrresd commented May 19, 2025

Uh oh!

ftorrresd commented May 19, 2025

Uh oh!

cmsbuild commented May 19, 2025

Uh oh!

antoniovilela commented May 20, 2025

Uh oh!

hqucms commented May 20, 2025

Uh oh!

cmsbuild commented May 20, 2025

Uh oh!

antoniovilela commented May 20, 2025

Uh oh!

Uh oh!

Uh oh!

Fix SoftMuonMvaRun3Estimator for NaN chi2 (PromptReco issue) #48115

Fix SoftMuonMvaRun3Estimator for NaN chi2 (PromptReco issue) #48115

Uh oh!

Conversation

gpetruc commented May 18, 2025

PR description:

PR validation:

Uh oh!

cmsbuild commented May 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented May 18, 2025

Uh oh!

cmsbuild commented May 18, 2025

Uh oh!

gpetruc commented May 18, 2025

Uh oh!

cmsbuild commented May 18, 2025

Comparison Summary

Uh oh!

jfernan2 commented May 19, 2025

Uh oh!

ftorrresd commented May 19, 2025

Uh oh!

ftorrresd commented May 19, 2025

Uh oh!

cmsbuild commented May 19, 2025

Comparison Summary

NANO Comparison Summary

Uh oh!

antoniovilela commented May 20, 2025

Uh oh!

hqucms commented May 20, 2025

Uh oh!

cmsbuild commented May 20, 2025

Uh oh!

antoniovilela commented May 20, 2025

Uh oh!

Uh oh!

Uh oh!

cmsbuild commented May 18, 2025 •

edited

Loading