Skip to content

Fix initialisation / deactivation of XercesC in OMTF emulator code #48160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2025

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented May 23, 2025

PR description:

This fixes a segmentation violation issue caused by direct initialisation / deactivation of XercesC in OMTF emulator code reported in #48090.
As proposed in #48090 direct calls of XMLPlatformUtils::Initialize()/Terminate() are replaced by calls with the cms::concurrency::xercesInitialize()/xercesTerminate().

PR validation:

Tested with WFs 145.005, 145.006 with 4 threads: runTheMatrix.py --nThreads 4 -l 145.005,145.006 -i all --ibeos

Should it be backported to 15_0_X (other?)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 23, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbluj for master.

It involves the following packages:

  • L1Trigger/L1TCommon (l1)
  • L1Trigger/L1TMuonOverlap (l1)
  • L1Trigger/L1TMuonOverlapPhase1 (l1)

@BenjaminRS, @cmsbuild, @quinnanm can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @dinyar, @eyigitba, @missirol, @mmusich, @thomreis this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@quinnanm
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 44KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02f26c/46346/summary.html
COMMIT: e1b3b3e
CMSSW: CMSSW_15_1_X_2025-05-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48160/46346/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4038193
  • DQMHistoTests: Total failures: 22
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4038151
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@quinnanm
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0e4cb56 into cms-sw:master May 24, 2025
11 checks passed
@mbluj
Copy link
Contributor Author

mbluj commented May 26, 2025

Hi @BenjaminRS, @quinnanm, could you confirm that a backport of this fix to 15_ 0 (or older) is not needed? Thanks.

@BenjaminRS
Copy link
Contributor

@iarspider -- can you perhaps comment here please? Do we need a backport of this fix for 15_0_X or previous releases?

@iarspider
Copy link
Contributor

@BenjaminRS no idea, unfortunately. Maybe @cms-sw/orp-l2 can comment?

@mandrenguyen
Copy link
Contributor

@BenjaminRS no idea, unfortunately. Maybe @cms-sw/orp-l2 can comment?

Looks like it wouldn't hurt. Might as well avoid relval issues in the production release.

@mbluj
Copy link
Contributor Author

mbluj commented May 26, 2025

@BenjaminRS no idea, unfortunately. Maybe @cms-sw/orp-l2 can comment?

Looks like it wouldn't hurt. Might as well avoid relval issues in the production release.

OK, I will backport it shortly then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants