-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Fix initialisation / deactivation of XercesC in OMTF emulator code #48160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48160/44932 |
A new Pull Request was created by @mbluj for master. It involves the following packages:
@BenjaminRS, @cmsbuild, @quinnanm can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Please test |
+1 Size: This PR adds an extra 44KB to repository Comparison SummarySummary:
|
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Hi @BenjaminRS, @quinnanm, could you confirm that a backport of this fix to 15_ 0 (or older) is not needed? Thanks. |
@iarspider -- can you perhaps comment here please? Do we need a backport of this fix for |
@BenjaminRS no idea, unfortunately. Maybe @cms-sw/orp-l2 can comment? |
Looks like it wouldn't hurt. Might as well avoid relval issues in the production release. |
OK, I will backport it shortly then. |
PR description:
This fixes a segmentation violation issue caused by direct initialisation / deactivation of XercesC in OMTF emulator code reported in #48090.
As proposed in #48090 direct calls of
XMLPlatformUtils::Initialize()/Terminate()
are replaced by calls with thecms::concurrency::xercesInitialize()/xercesTerminate()
.PR validation:
Tested with WFs 145.005, 145.006 with 4 threads:
runTheMatrix.py --nThreads 4 -l 145.005,145.006 -i all --ibeos
Should it be backported to 15_0_X (other?)