Skip to content
This repository was archived by the owner on Jan 7, 2025. It is now read-only.

feat(core/df-repr): better upper bound pruning to reduce plan space #265

Merged
merged 7 commits into from
Dec 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
117 changes: 104 additions & 13 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 3 additions & 6 deletions datafusion-optd-cli/tests/cli_integration.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
// specific language governing permissions and limitations
// under the License.

use std::process::Command;
use std::process::{Command, Stdio};

use assert_cmd::prelude::CommandCargoExt;

Expand Down Expand Up @@ -55,11 +55,8 @@ fn init() {
fn cli_test_tpch() {
let mut cmd = Command::cargo_bin("datafusion-optd-cli").unwrap();
cmd.current_dir(".."); // all paths in `test.sql` assume we're in the base dir of the repo
cmd.args([
"--enable-df-logical",
"--file",
"datafusion-optd-cli/tpch-sf0_01/test.sql",
]);
cmd.args(["--file", "datafusion-optd-cli/tpch-sf0_01/test.sql"]);
cmd.stdout(Stdio::piped()).stderr(Stdio::piped());
let status = cmd.status().unwrap();
assert!(
status.success(),
Expand Down
2 changes: 2 additions & 0 deletions optd-core/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ serde = { version = "1.0", features = ["derive", "rc"] }
arrow-schema = "53.3.0"
chrono = "0.4"
erased-serde = "0.4"
pollster = "0.4"
stacker = "0.1"

[dev-dependencies]
pretty_assertions = "1.4.1"
4 changes: 2 additions & 2 deletions optd-core/src/cascades.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

mod memo;
mod optimizer;
mod tasks;
pub mod rule_match;
mod tasks2;

pub use memo::{Memo, NaiveMemo};
pub use optimizer::{CascadesOptimizer, ExprId, GroupId, OptimizerProperties, RelNodeContext};
use tasks::Task;
9 changes: 8 additions & 1 deletion optd-core/src/cascades/memo.rs
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,11 @@ pub trait Memo<T: NodeType>: 'static + Send + Sync {
) -> Result<ArcPlanNode<T>> {
get_best_group_binding_inner(self, group_id, &mut post_process)
}

/// Get winner of a group and a subgroup.
fn get_group_winner(&self, group_id: GroupId) -> &Winner {
&self.get_group(group_id).info.winner
}
}

fn get_best_group_binding_inner<M: Memo<T> + ?Sized, T: NodeType>(
Expand Down Expand Up @@ -302,6 +307,7 @@ impl<T: NodeType> Memo<T> for NaiveMemo<T> {
self.expr_id_to_expr_node[expr_id]
);
}
let group_id = self.reduce_group(group_id);
let grp = self.groups.get_mut(&group_id);
grp.unwrap().info = group_info;
}
Expand Down Expand Up @@ -352,7 +358,8 @@ impl<T: NodeType> NaiveMemo<T> {
}

fn verify_integrity(&self) {
if cfg!(debug_assertions) {
const ENABLE_INTEGRITY_CHECK: bool = false;
if ENABLE_INTEGRITY_CHECK {
let num_of_exprs = self.expr_id_to_expr_node.len();
assert_eq!(num_of_exprs, self.expr_node_to_expr_id.len());
assert_eq!(num_of_exprs, self.expr_id_to_group_id.len());
Expand Down
Loading
Loading