Skip to content

release-23.2: opt: fix hints for placeholder fast path #147413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented May 28, 2025

Backport 1/1 commits from #147368 on behalf of @mgartner.


Fixes #147363

Release note (bug fix): A bug has been fixed that cause the optimizer to
ignore index hints when optimizing some forms of prepared statements.
This could result in one of two unexepcted behaviors: a query errors
with the message "index cannot be used for this query" when the index
can actually be used, or query using an index that does not adhere to
the hint. The hints relevant to this bug are regular index hints, e.g.,
SELECT * FROM tab@index, FORCE_INVERTED_INDEX and FORCE_ZIGZAG.


Release justification:

Fixes #147363

Release note (bug fix): A bug has been fixed that cause the optimizer to
ignore index hints when optimizing some forms of prepared statements.
This could result in one of two unexepcted behaviors: a query errors
with the message "index cannot be used for this query" when the index
can actually be used, or query using an index that does not adhere to
the hint. The hints relevant to this bug are regular index hints, e.g.,
`SELECT * FROM tab@index`, `FORCE_INVERTED_INDEX` and `FORCE_ZIGZAG`.
@blathers-crl blathers-crl bot requested a review from a team as a code owner May 28, 2025 14:53
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-147368 branch from 9160ace to 6d04a48 Compare May 28, 2025 14:53
@blathers-crl blathers-crl bot requested review from michae2 and removed request for a team May 28, 2025 14:53
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels May 28, 2025
@blathers-crl blathers-crl bot requested a review from DrewKimball May 28, 2025 14:53
Copy link
Author

blathers-crl bot commented May 28, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label May 28, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in slack, I think we should hold off on this one, just in case anyone's workload is using bad hints that are currently ignored.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @DrewKimball)

@mgartner
Copy link
Collaborator

Agreed. backport-all was just easier 😉.

@mgartner mgartner closed this May 29, 2025
@mgartner mgartner deleted the blathers/backport-release-23.2-147368 branch May 29, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants