Add Cast for JSON #265
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| <?php | ||
|
|
||
| namespace Colopl\Spanner\Casts; | ||
|
|
||
| use Google\Cloud\Spanner\PgJsonb; | ||
| use Google\Cloud\Spanner\V1\TypeAnnotationCode; | ||
| use Illuminate\Contracts\Database\Eloquent\CastsAttributes; | ||
| use Illuminate\Database\Eloquent\Model; | ||
|
|
||
| /** | ||
| * @implements CastsAttributes<mixed, mixed> | ||
| * */ | ||
| class SpannerJson implements CastsAttributes | ||
| { | ||
| public function get(Model $model, string $key, mixed $value, array $attributes) | ||
| { | ||
| if($value === null) { | ||
| return null; | ||
| } | ||
|
|
||
| if($value instanceof SpannerJsonType) { | ||
| $value = (string) $value; | ||
| } | ||
|
|
||
| if(!is_string($value)) { | ||
| throw new \InvalidArgumentException('The given value must be a string, SpannerJsonType or null'); | ||
| } | ||
|
|
||
| return json_decode($value, true); | ||
| } | ||
|
|
||
| public function set(Model $model, string $key, mixed $value, array $attributes) | ||
| { | ||
| if ( | ||
| !is_array($value) && | ||
| !$value instanceof \JsonSerializable && | ||
| $value !== null && | ||
| !is_string($value) | ||
| ) { | ||
| throw new \InvalidArgumentException('The given value must be an array, JsonSerializable, string or null.'); | ||
| } | ||
|
|
||
| return [$key => new SpannerJsonType($value)]; | ||
| } | ||
| } | ||
|
|
||
|
|
||
| class SpannerJsonType extends PgJsonb | ||
| { | ||
| public function typeAnnotation(): int | ||
| { | ||
| return TypeAnnotationCode::TYPE_ANNOTATION_CODE_UNSPECIFIED; | ||
| } | ||
| } | ||
|
Comment on lines
+1
to
+54
There was a problem hiding this comment. 💡 Verification agent 🧩 Analysis chainDocument expected behavior for numeric JSON keys. JSON objects can have numeric keys, but PHP arrays convert these to integers which can cause unexpected behavior when encoding/decoding between PHP and JSON formats. Please document or consider handling the case where JSON data contains numeric strings as keys, which might be transformed during the encode/decode process. 🏁 Script executed: #!/bin/bash
# Create a sample PHP script to test numeric key behavior
cat > test_json_keys.php << 'EOF'
<?php
// Test case with numeric string keys
$jsonWithNumericKeys = '{"1": "value1", "2": "value2"}';
$decoded = json_decode($jsonWithNumericKeys, true);
echo "Original JSON: $jsonWithNumericKeys\n";
echo "Decoded array: " . print_r($decoded, true) . "\n";
$reencoded = json_encode($decoded);
echo "Re-encoded JSON: $reencoded\n";
echo "Are they identical? " . ($jsonWithNumericKeys === $reencoded ? "Yes" : "No") . "\n";
EOF
# Run the test script
php test_json_keys.phpLength of output: 206 Update Documentation on Numeric JSON Key Conversion Behavior The test confirms that when decoding JSON with numeric string keys, PHP converts these keys to integers. When re-encoding, the keys are output as strings—which causes the re-encoded JSON not to be byte-identical to the original (e.g., extra whitespace differences aside, the numeric keys’ types have shifted). Please update the documentation to clearly explain this behavior in the context of the casting logic in
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Verification inconclusive
Missing import for SpannerJsonType class.
The
SpannerJsonTypeclass is used but not imported. This will cause a runtime error.+use Colopl\Spanner\Query\Grammar\SpannerJsonType; namespace Colopl\Spanner\Casts;Please verify the correct namespace and path for the
SpannerJsonTypeclass in your codebase.🏁 Script executed:
Length of output: 129
Verify Missing Import for SpannerJsonType
The code instantiates a new
SpannerJsonType($value)on line 36 ofsrc/Casts/SpannerJson.phpwithout an import. We attempted to verify its existence using a search for a class declaration but did not find a matching definition. Please manually verify whether theSpannerJsonTypeclass exists in the codebase:use Colopl\Spanner\Query\Grammar\SpannerJsonType;is unconfirmed).