chore: deprecate unused SchemaBuilder methods #277
Conversation
WalkthroughThe Changes
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
taka-oyama
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/Schema/Builder.php (2)
57-58: Suggest adding runtime deprecation warning and version metadata
The@deprecateddocblock is a good first step, but developers may overlook it. Enhance clarity by specifying the version since deprecation (e.g.,since v9.0) and emit a runtime notice viatrigger_error().@@ class Builder { - /** - * @deprecated Use Blueprint::dropIndex() instead. Will be removed in v10.0. + /** + * @deprecated since v9.0 Use Blueprint::dropIndex() instead. Will be removed in v10.0. @@ public function dropIndex($table, $name) + trigger_error( + __METHOD__ . ' is deprecated and will be removed in v10.0. Use Blueprint::dropIndex() instead.', + E_USER_DEPRECATED + ); $blueprint = $this->createBlueprint($table); $blueprint->dropIndex($name); $this->build($blueprint);
71-72: Suggest adding runtime deprecation warning and version metadata
Apply the same enhancement todropIndexIfExist: includesinceversion in the docblock and trigger aE_USER_DEPRECATEDnotice at the top of the method.@@ class Builder { - /** - * @deprecated Use Blueprint::dropIndex() instead. Will be removed in v10.0. + /** + * @deprecated since v9.0 Use Blueprint::dropIndex() instead. Will be removed in v10.0. @@ public function dropIndexIfExist($table, $name) + trigger_error( + __METHOD__ . ' is deprecated and will be removed in v10.0. Use Blueprint::dropIndex() instead.', + E_USER_DEPRECATED + ); if (in_array($name, $this->getIndexes($table), true)) { $blueprint = $this->createBlueprint($table); $blueprint->dropIndex($name);
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/Schema/Builder.php(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Run-PHPUnit
Summary by CodeRabbit