Skip to content

Fix java code generator emitting unknown None symbol #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mvdbeek
Copy link
Contributor

@mvdbeek mvdbeek commented Aug 18, 2024

Quite similar to 6d85020 and fixes building the java code for gxformat2.

Quite similar to common-workflow-language@6d85020
and fixing building the java code for gxformat2.
@mvdbeek mvdbeek force-pushed the fix_none_in_java_code_generator branch from 5c5d263 to 2b3a9c3 Compare August 18, 2024 10:46
@mvdbeek mvdbeek force-pushed the fix_none_in_java_code_generator branch from 3d10e44 to 065b050 Compare August 18, 2024 11:29
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.03%. Comparing base (71398c9) to head (065b050).
Report is 42 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #858   +/-   ##
=======================================
  Coverage   83.03%   83.03%           
=======================================
  Files          22       22           
  Lines        4834     4834           
  Branches     1310     1310           
=======================================
  Hits         4014     4014           
  Misses        545      545           
  Partials      275      275           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mvdbeek !

@mr-c mr-c merged commit 659a884 into common-workflow-language:main Aug 18, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants