-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Investigate new compatibility check strategy #18396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
AbrilRBS
wants to merge
15
commits into
conan-io:develop2
Choose a base branch
from
AbrilRBS:ar/new-compatibility-arti-endpoint
base: develop2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Investigate new compatibility check strategy #18396
AbrilRBS
wants to merge
15
commits into
conan-io:develop2
from
AbrilRBS:ar/new-compatibility-arti-endpoint
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
reviewed
Jun 2, 2025
We're now looking for timings from different use-cases and will post the results after we've gathered them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: (Feature | Fix | Bugfix): Describe here your pull request
Docs: https://github.com/conan-io/docs/pull/XXXX
The idea is to use the search for all package ids inside a recipe revision instead of querying one by one, which even when the server has to parse all the conaninfo, it will be faster most of the time in old implementations.
The key here is to have a new optional parameter in the
search_packages
endpoint to let the user know we don't need info about each package id, and that it should not parse the conaninfo, which speeds up the lookup in a backwards compatible way that does not need to create a new endpointThe idea is to then upstream support for this new parameter to Artifactory,
alongside a report of the new timings for a variety of situations