Multi-architecture support for s3-resource Dockerfile #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analytically
force-pushed
the
multi_wolfi
branch
2 times, most recently
from
8820f8f to
b2ce380
Compare
11 tasks
Enhanced the Dockerfile with multi-architecture support using Docker BuildX. Key changes: - Added TARGETOS and TARGETARCH arguments for cross-compilation - Utilized BUILDPLATFORM for efficient builder image compilation - Set explicit GOOS/GOARCH/GOAMD64/GOARM64 flags for optimized binaries - Updated package management for Chainguard base image - Preserved test execution in target-specific environments This enables building optimized s3-resource containers for multiple architectures (amd64, arm64) from a single build pipeline, with architecture-specific instruction set targeting. Signed-off-by: Mathias Bogaert <[email protected]>
analytically
force-pushed
the
multi_wolfi
branch
from
b2ce380 to
138ef86
Compare
and the TARGET{OS/ARCH} as Go will figure that out from the platform
specified by buildkit.
Changed the builder_image to concourse/golang-builder as we set some
non-default stuff in that image. See the concourse/ci repo for the
Dockerfile for that image.
Signed-off-by: Taylor Silva <[email protected]>
|
Changed PR to a draft until the ci pipeline stuff is ready. Added a commit to clean some stuff. See commit message for details. |
analytically
commented
Apr 18, 2025
| tzdata \ | ||
| unzip \ | ||
| zip && \ | ||
| rm -rf /var/cache/apk/* |
There was a problem hiding this comment.
no need for this when using --no-cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to concourse/concourse#9183
Updated the Dockerfile to support multi-architecture builds. Key changes:
Added TARGETOS and TARGETARCH arguments for cross-compilationSet builder to use BUILDPLATFORM for faster buildsConfigured Go builds with explicit GOOS/GOARCH for target platformsThis enables building the s3-resource container for multiple architectures (amd64, arm64, etc.) from a single build pipeline.